Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximized window get smaller when screen is rotated. #750

Closed
pitigalari opened this issue Aug 26, 2019 · 7 comments
Closed

Maximized window get smaller when screen is rotated. #750

pitigalari opened this issue Aug 26, 2019 · 7 comments
Labels

Comments

@pitigalari
Copy link

When the window is maximized, and if the android device rotates, the window becomes smaller and gets fixed in the top left corner of the screen.

Windows 7 Ultimate Service pack 1
Android 7.1.2
Connection: USB

Untitled-1

@rom1v
Copy link
Collaborator

rom1v commented Aug 26, 2019

When you rotate, it computes the target size, then make it fit inside the display, with some margins (as it does when you start scrcpy), keeping its (top-left) position unchanged.

In that case, it's clearly not ideal, but I'm not sure what is the expected behavior.

@pitigalari
Copy link
Author

My expected behaviour is that it would automatically maximize the screen once again after resizing if it's been maximized before rotating the screen.

@rom1v
Copy link
Collaborator

rom1v commented Aug 26, 2019

Oh, it was maximized! Sorry, I missed that part :)

@rom1v
Copy link
Collaborator

rom1v commented Aug 26, 2019

(btw, just for info, instead of maximizing, you could switch to fullscreen with Ctrl+f. I say that because I see people just maximizing while they would prefer fullscreen.)

@rom1v rom1v added the bug label Aug 29, 2019
@rom1v rom1v changed the title BUG: Maximized window get smaller when screen is rotated. Maximized window get smaller when screen is rotated. Aug 29, 2019
@pitigalari
Copy link
Author

Issue doesn't appear in fullscreen mode (Ctrl+f). Problem exists only when the window is maximized.

rom1v added a commit that referenced this issue Nov 11, 2019
Keep the windowed window size to handle maximized window the same way as
fullscreen window.

Fixes <#750>
@rom1v
Copy link
Collaborator

rom1v commented Nov 11, 2019

Fixed in dev.

@rom1v rom1v closed this as completed Nov 12, 2019
@vbuterin2
Copy link

use lock video --lock-video-orientation=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants