Encoding profile option #1226

tzah4748 · 2020-03-19T18:33:57Z

There are some decoders like Broadway that can accept only H.264 Baseline profile streams.
This profile is considered the most generic and is available on most Android devices.
To allow selecting a profile new option has been added to client and server.

If the option is not requested with -c then the codec will be automatically choosen by the MediaCodec. (cherry picked from commit 43aea79)

(cherry picked from commit d4fb6a0) (cherry picked from commit e7f205c) (cherry picked from commit ef5d72c)

(cherry picked from commit 2505242)

(cherry picked from commit 7e36540) (cherry picked from commit ef95046) (cherry picked from commit fa3644c)

(cherry picked from commit e158243) (cherry picked from commit a4ef318) (cherry picked from commit a5b83c1)

(cherry picked from commit fa56950)

app/src/cli.c

rom1v · 2020-03-19T18:41:15Z

app/src/cli.c

@@ -431,6 +466,7 @@ scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) {
        {"window-height",          required_argument, NULL, OPT_WINDOW_HEIGHT},
        {"window-borderless",      no_argument,       NULL,
                                                  OPT_WINDOW_BORDERLESS},
+        {"codec-profile",          required_argument, NULL, 'P'},


This is an advanced option, I would prefer not to consume a "short" option (-P) for that.

Yes that's totally fine, at first i had a bit of a problem understanding the code so i didn't know if it will work without a short version of the option, its ok to remove it -P and stay with --codec-profile only

tzah4748 · 2020-03-19T18:58:56Z

Passing an invalid value will not start, and the level is selected only if the profile is valid. The possible levels of the codec are decided on runtime depending on the screen size (i think, not sure) so i dont think its something you need to pick anyway.

…

On Thu, Mar 19, 2020 at 8:55 PM Romain Vimont ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/src/cli.c <#1226 (comment)>: > + bool ok = parse_integer_arg(optarg, &value, true, 0, 0x7FFFFFFF, "codec-profile"); + if (!ok) { + return false; + } + + switch (value) { + case 0: // Automatic + case 0x01: // AVCProfileBaseline + case 0x02: // AVCProfileMain + case 0x04: // AVCProfileExtended + case 0x08: // AVCProfileHigh + case 0x10: // AVCProfileHigh10 + case 0x20: // AVCProfileHigh422 + case 0x40: // AVCProfileHigh444 + case 0x10000: // AVCProfileConstrainedBaseline + case 0x80000: // AVCProfileConstrainedHigh (oh but then passing another value than the "valid" ones will cause problems because level is selected automatically) Maybe we could just pass --codec-profile=value and --codec-level=value? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEPZYSDXX5KXAV2AKYGLRIJTCNANCNFSM4LPQPYUA> .

rom1v · 2020-03-19T20:09:04Z

What if you don't set the level value at all on the MediaFormat (only the profile)?

tzah4748 · 2020-03-20T08:34:22Z

I didn't test but maybe it will be choosen automatically? The level option is only from api 23 and not 21 so its something that was added after the profile

…

On Thu, Mar 19, 2020, 10:09 PM Romain Vimont ***@***.***> wrote: What if you don't set the level value at all on the MediaFormat (only the profile)? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEP3K3DVBKJOBSCOIFZDRIJ3W3ANCNFSM4LPQPYUA> .

rom1v · 2020-03-20T09:02:52Z

If the level is chosen automatically when not set, then maybe an option --codec-profile accepting any integer and a --codec-level accepting any integer (ignored if API < 23) would be better?

tzah4748 · 2020-03-20T09:06:34Z

And in case that the profile is found and the level isn't it will be choosen automatically, seems right.

…

On Fri, Mar 20, 2020, 11:03 AM Romain Vimont ***@***.***> wrote: If the level is chosen automatically when not set, then maybe an option --codec-profile accepting any integer and a --codec-level accepting any integer (ignored if API < 23) would be better? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEP6UTMMV2YK6AFZQ7H3RIMWM3ANCNFSM4LPQPYUA> .

rom1v · 2020-03-20T09:46:13Z

Oh, maybe we could do it very generically: instead of adding codec options when people need them, we could just pass a string of key=value.

For example:

scrcpy --codec-options profile=1,level=2

The String would be passed as-is from the client to the server, and the server would parse it and set the media options.

There is an additional detail: the type depends on the key. Some expect an integer value, some others a long, some others a string.

Since almost all are integers, I suggest to use integer by default.
Otherwise, we could specify the type:

--codec-options somekey:string=value

What do you think?

tzah4748 · 2020-03-20T10:10:34Z

And what if a person doesn't want to specify a level ? Just the profile? I personally liked it better when it's separated even though they are related.

…

On Fri, Mar 20, 2020, 11:46 AM Romain Vimont ***@***.***> wrote: Oh, maybe we could do it very generically: instead of adding codec options when people need them, we could just pass a string of key=value. For example: scrcpy --codec-options profile=1,level=2 The String would be passed as-is from the client to the server, and the server would parse it and set the media options. There is an additional detail: the type depends on the key. Some expect an integer value, some others a long, some others a string. Since almost all are integers, I suggest to use integer by default. Otherwise, we could specify the type: --codec-options somekey:string=value What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEPYOTL4NI3LXZR44LZDRIM3PHANCNFSM4LPQPYUA> .

rom1v · 2020-03-20T10:28:13Z

And what if a person doesn't want to specify a level ? Just the profile?

Yes, the idea is to pass anything you want from MediaFormat.

scrcpy --codec-options key1:value1,key2=value2,...,keyn=valuen

Scrcpy would not even "understand" that it's a profile or a level, it just sets the value to the MediaFormat instance.

tzah4748 · 2020-03-20T10:45:26Z

I don't think i understood what you meant but if you see it fit and more logical that way its fine :)

…

On Fri, Mar 20, 2020 at 12:28 PM Romain Vimont ***@***.***> wrote: And what if a person doesn't want to specify a level ? Just the profile? Yes, the idea is to pass anything you want from MediaFormat <https://developer.android.com/reference/android/media/MediaFormat>. scrcpy --codec-options key1:value1,key2=value2,...,keyn=valuen Scrcpy would not even "understand" that it's a profile or a level, it just sets the value to the MediaFormat instance. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEP5DFPJQ6ZQ7VKUQXRDRINAMZANCNFSM4LPQPYUA> .

rom1v · 2020-03-20T10:48:37Z

I don't think i understood what you meant

Instead of --codec-level, --codec-profile, --codec-something options, we could have only one option: --codec-options passing all key/values as a single string.

That way, one could pass any present and future codec options as they need.

rom1v · 2020-03-21T21:07:56Z

@tzah4748 Are you ok for implementing such a --codec-options parameter instead of a specific option --codec-profile?

tzah4748 · 2020-03-22T07:55:07Z

Yes i'll do it, it will take some time I am quite busy with other work for now. I'll commit the changes once ill get to it :)

…

On Sat, Mar 21, 2020 at 11:08 PM Romain Vimont ***@***.***> wrote: @tzah4748 <https://github.com/tzah4748> Are you ok for implementing such a --codec-options parameter instead of a specific option --codec-profile? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI3FEP6MCKDH3M25ZPI3CCTRIUUDZANCNFSM4LPQPYUA> .

tzah4748 · 2020-04-17T17:36:05Z

@rom1v Opened a new PR with what we talked about.

rom1v · 2020-05-03T23:53:18Z

Reopen (see #1325 (review))

rom1v · 2020-05-05T17:31:35Z

On my device (after fixing compilation errors), it does not work as is (of course, it works without --codec-profile):

$ scrcpy --codec-profile 2
[server] ERROR: Exception on thread Thread[main,5,main]
android.media.MediaCodec$CodecException: Error 0xfffffc0e
	at android.media.MediaCodec.native_configure(Native Method)
	at android.media.MediaCodec.configure(MediaCodec.java:1778)
	at com.genymobile.scrcpy.ScreenEncoder.configure(ScreenEncoder.java:191)
	at com.genymobile.scrcpy.ScreenEncoder.streamScreen(ScreenEncoder.java:76)
	at com.genymobile.scrcpy.Server.scrcpy(Server.java:35)
	at com.genymobile.scrcpy.Server.main(Server.java:170)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:251)

Computed max level is 65536 (0x10000, AVCLevel52). If I programmatically set level to 4096 (0x1000, AVCLevel41), it works.

Therefore, I think using the max available level for the given profile is not a good strategy 😕

rom1v · 2020-05-05T17:39:33Z

Oh I guess it requires changes from #1296?

tzah4748 · 2020-05-06T10:43:53Z

@rom1v Yes Rom, in #1296 I've added logic to choose the right level depending on the device screen size.
It should depend on the bit-rate as well but i ignored it for now (since i wasn't sure if its really needed) and it worked just fine.
In short, it has suggested level logic

rom1v · 2020-05-06T19:37:36Z

OK, thank you for your answer. 👍

If selecting a correct level based on the profile was straightforward, I would be in favor on doing it automatically.

However, it seems complicated, so it would add complex code to maintain, and to modify when scrcpy will support other codecs, for a very advanced option. Therefore, I think I prefer that the user provide both profile and level (like #1325).

tzah4748 · 2020-05-12T16:09:22Z

@rom1v are you gonna do it yourself or you are waiting a new pull request?

rom1v · 2020-05-12T20:39:31Z

are you gonna do it yourself or you are waiting a new pull request?

I have a working branch (codec_options), I might merge it before the next release.

tzah4748 · 2020-05-20T11:49:26Z

@rom1v That's great news!
Do you maybe have an ETA when is the next release?

Add a command-line parameter to pass custom options to the device encoder (as a comma-separated list of "key[:type]=value"). The list of possible codec options is available in the Android documentation: <https://d.android.com/reference/android/media/MediaFormat> PR #1325 <#1325> Refs #1226 <#1226> Co-authored-by: Romain Vimont <rom@rom1v.com>

rom1v · 2020-05-24T12:56:29Z

Merged #1325 into dev.

Tzah Mazuz added 6 commits March 19, 2020 17:31

Adding codec_profile to scrcpy client default options.

504d6a4

If the option is not requested with -c then the codec will be automatically choosen by the MediaCodec. (cherry picked from commit 43aea79)

Adding codecProfile to server options

709a0c3

(cherry picked from commit d4fb6a0) (cherry picked from commit e7f205c) (cherry picked from commit ef5d72c)

Adding codecProfile and setCodecProfile to the ScreenEncoder

a9685d3

(cherry picked from commit 2505242)

Fix the printed versions (were opposite)

a5d5ea1

(cherry picked from commit 7e36540) (cherry picked from commit ef95046) (cherry picked from commit fa3644c)

Added help and parsing of the codec-profile option

1e3321c

(cherry picked from commit e158243) (cherry picked from commit a4ef318) (cherry picked from commit a5b83c1)

Adding codec-profile option to the server exec params

e49657a

(cherry picked from commit fa56950)

rom1v reviewed Mar 19, 2020

View reviewed changes

alligatorme mentioned this pull request Mar 24, 2020

I got SPS profile_idc 100, can I set profile_idc 66 (baseline)? #510

Closed

rom1v mentioned this pull request Apr 9, 2020

Encoder Options? #328

Closed

tzah4748 closed this Apr 17, 2020

rom1v mentioned this pull request Apr 18, 2020

Encoding options #1296

Closed

rom1v reopened this May 3, 2020

rom1v closed this May 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encoding profile option #1226

Encoding profile option #1226

tzah4748 commented Mar 19, 2020

rom1v Mar 19, 2020

tzah4748 Mar 19, 2020

tzah4748 commented Mar 19, 2020 via email

rom1v commented Mar 19, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020 •

edited

Loading

rom1v commented Mar 21, 2020

tzah4748 commented Mar 22, 2020 via email

tzah4748 commented Apr 17, 2020

rom1v commented May 3, 2020

rom1v commented May 5, 2020

rom1v commented May 5, 2020

tzah4748 commented May 6, 2020

rom1v commented May 6, 2020

tzah4748 commented May 12, 2020

rom1v commented May 12, 2020

tzah4748 commented May 20, 2020

rom1v commented May 24, 2020

Encoding profile option #1226

Encoding profile option #1226

Conversation

tzah4748 commented Mar 19, 2020

rom1v Mar 19, 2020

Choose a reason for hiding this comment

tzah4748 Mar 19, 2020

Choose a reason for hiding this comment

tzah4748 commented Mar 19, 2020 via email

rom1v commented Mar 19, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020

tzah4748 commented Mar 20, 2020 via email

rom1v commented Mar 20, 2020 • edited Loading

rom1v commented Mar 21, 2020

tzah4748 commented Mar 22, 2020 via email

tzah4748 commented Apr 17, 2020

rom1v commented May 3, 2020

rom1v commented May 5, 2020

rom1v commented May 5, 2020

tzah4748 commented May 6, 2020

rom1v commented May 6, 2020

tzah4748 commented May 12, 2020

rom1v commented May 12, 2020

tzah4748 commented May 20, 2020

rom1v commented May 24, 2020

rom1v commented Mar 20, 2020 •

edited

Loading