Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update brew command #2231

Closed
wants to merge 23 commits into from
Closed

update brew command #2231

wants to merge 23 commits into from

Conversation

quyleanh
Copy link
Contributor

@quyleanh quyleanh commented Apr 2, 2021

brew cask was deprecated according to this comment. Should be brew install.

natanjunges and others added 19 commits January 15, 2021 10:17
@natanjunges @rom1v
Update README.pt-br to v1.17
af516e3 
PR #2034 <#2034>

Reviewed-by: latreta <yves_henry13@hotmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
@yume-chan @rom1v
Update README.zh-Hans to v1.17
ce43fad 
PR #2029 <#2029>

Reviewed-by: Win7GM
Signed-off-by: Romain Vimont <rom@rom1v.com>
@mcr @rom1v
Update java version in BUILD.md
f8524a2 
PR #2064 <#2064>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Fix release instructions in BUILD.md
a2919b3 
Makefile.CrossWindows have been renamed to release.mk, which is called
from release.sh.
@rom1v
Update another java version in BUILD.md
7b51a03 
Commit f8524a2 updated one reference to
the openjdk package, but there was another one.
@yangfl @rom1v
Remove unnecessary escape characters in manpage
1863ca7 
PR #2123 <#2123>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Mention adb debugging in FAQ
08baaf4
@rom1v
Remove obsolete FAQ entry
dca11f6 
Issue #15 had been fixed in v1.14 by
e40532a.
@rom1v
Add "Get the app" summary section
19ad107 
Give quick instructions to download/install scrcpy.
@rom1v
Fix typo in README
1fb7957 
Refs <#2195 (comment)>
@rom1v
Improve --push-target example in README
3a4b10a 
A common use case for the --push-target option is to pass the device
Download directory.
@aruko-210 @rom1v
Add Japanese translation for README.md
6a217b7 
PR #2195 <#2195>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Link release to main README in translations
8414b68 
This avoids to link an older version.
@rom1v
Fix typo in BUILD.md
38f392f
@rom1v
Fix BUILD.md line wrapping
fda293f
@FossPrime @rom1v
Clarify the order of operations in BUILD.md
fc5de88 
PR #2223 <#2223>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Add simplified installation script
47d16a5 
Add a script to download the server and build scrcpy using the
prebuilt server.
@rom1v
Add instructions to uninstall
b77932a
@quyleanh
update brew command
e2d5af3 
`brew cask` was deprecated according to [this comment](Homebrew/discussions#340 (comment)). Should be `brew install`.
@rom1v
Copy link
Collaborator

rom1v commented Apr 2, 2021 •
edited

Thank you.

I have several questions because I don't use macOS/homebrew:

Isn't --cask necessary? like here: 192fbd8 (#2004)

What is the latest openjdk version available? For consistency, could it be changed from 8 to 11?
(see f8524a2 and 7b51a03)

@quyleanh
Copy link
Contributor Author

quyleanh commented Apr 2, 2021

Isn't --cask necessary?

No, for now there is no --cask option anymore.

What is the latest openjdk version available?

For now, the latest openjdk is version 16. However we can use openjdk version 8 LTS or version 11 LTS.

@quyleanh quyleanh changed the base branch from master to dev April 2, 2021 14:45
rom1v pushed a commit that referenced this pull request Apr 4, 2021
@quyleanh @rom1v
Update brew cask documentation
d50c678 
The command `brew cask` has been deprecated:
<Homebrew/discussions#340 (comment)>

Should be `brew install` directly now.

PR #2231 <#2231>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Apr 4, 2021

I rebased/squashed.

Is this commit ok for you d50c678?
I also added 2812de8 after your commit, is it ok?

(They are not merged yet, I'll merge after your confirmation.)

@quyleanh
Copy link
Contributor Author

quyleanh commented Apr 4, 2021

Yes. It's ok for me.

@rom1v
Copy link
Collaborator

rom1v commented Apr 4, 2021

Thank you. Merged into master.

@rom1v rom1v closed this Apr 4, 2021
@quyleanh quyleanh deleted the patch-1 branch April 4, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@quyleanh @rom1v @natanjunges @yume-chan @mcr @yangfl @aruko-210 @FossPrime