Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press 2x extra mouse button to open settings #2264

Closed
wants to merge 5 commits into from
Closed

Press 2x extra mouse button to open settings #2264

wants to merge 5 commits into from

Conversation

brunoais
Copy link
Contributor

Requires #2260

@brunoais
Count repeat presses of the keyboard shortcut
eec25f6 
Allows shortcuts such as:
CTRL + n + n to open the settings panel
@brunoais
Rename COLLAPSE_NOTIFICATION_PANEL -> COLLAPSE_PANELS & consequences
caeb0ba 
The collapsing action collapses the panel whichever is open. Even in-app panels
@brunoais
Create the ability to open the settings panel
499f595
@brunoais
expandSettingsPanel() changed API with android 9
cd533a9 
Now it gets a parameter. However, it can be null
https://code.yawk.at/android/android-9.0.0_r35/android/app/StatusBarManager.java#android.app.StatusBarManager%23expandSettingsPanel(java.lang.String)
For now, I don't have android 10's but it's probably a version without the noargument method
@brunoais
Pressing 2x with the extra mouse button opens settings panel
9f39fca
@rom1v rom1v mentioned this pull request Apr 20, 2021
Closed
2 tasks
rom1v pushed a commit that referenced this pull request Apr 20, 2021
@brunoais @rom1v
Add mouse shortcut to expand settings panel
d2ae5be 
Double-click on extra mouse button to open the settings panel (a
single-click opens the notification panel).

This is consistent with the keyboard shortcut MOD+n+n.

PR #2264 <#2264>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Apr 20, 2021
@brunoais @rom1v
Add mouse shortcut to expand settings panel
aafedb0 
Double-click on extra mouse button to open the settings panel (a
single-click opens the notification panel).

This is consistent with the keyboard shortcut MOD+n+n.

PR #2264 <#2264>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Apr 25, 2021
@brunoais @rom1v
Add mouse shortcut to expand settings panel
b4ee9f2 
Double-click on extra mouse button to open the settings panel (a
single-click opens the notification panel).

This is consistent with the keyboard shortcut MOD+n+n.

PR #2264 <#2264>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Apr 25, 2021

Merged into dev.

@rom1v rom1v closed this Apr 25, 2021
@rom1v
Copy link
Collaborator

rom1v commented Jun 20, 2021

A minor inconsistency: with the keyboard shortcut, the settings panel is expanded regardless of the delay between the first MOD+n and the second. With the mouse, it only works with a double-click. Maybe it should work with a longer delay too? What do you think?

@brunoais
Copy link
Contributor Author

Sounds good to me. That feature acting consistent between both ways is better.

@rom1v
Copy link
Collaborator

rom1v commented Jun 20, 2021

OK, I noticed this when testing before releasing v1.18. But it's minor, so I still released. It can be fixed later 😉

@rom1v
Copy link
Collaborator

rom1v commented Jun 20, 2021

Maybe it should work with a longer delay too?

(Or maybe the keyboard shortcut should only work for a short delay (like a double click), I don't know which is better.)

@brunoais
Copy link
Contributor Author

After thinking for a while. I think both should have the reset after a short delay.
Any ideas on how to achieve that? I don't know SDL API well enough for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoais @rom1v