Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shake shortcut to README #2879

Closed
wants to merge 1 commit into from
Closed

Conversation

thomasvm
Copy link

As a react-native developer I was looking for a way trigger the shake gesture (to launch the development menu). Turns out it exists but was missing from the README. This pull request adds the shortcut to the shortcuts table

@rom1v
Copy link
Collaborator

rom1v commented Dec 14, 2021

This shortcut "Click on MENU (unlock screen)" (the fact that react-native binds MENU to "shake gesture" is a react-native detail).

Maybe it might be documented on the same line then:

Click on MENU (unlock screen, shake gesture)

What do you think?

@thomasvm
Copy link
Author

Thanks for the clarification. I adjusted the "Click on MENU (unlock screen)" to have a footnote with the react-native explanation

rom1v pushed a commit that referenced this pull request Dec 18, 2021
PR #2879 <#2879>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Dec 18, 2021

Thank you.

I reordered the footnotes, and moves the reference to the shortcut description (instead of the shortcut keys): pr2879. Is it ok for you? 25a4135

@thomasvm
Copy link
Author

Perfect!

@rom1v
Copy link
Collaborator

rom1v commented Dec 20, 2021

👍 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants