Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for NoSuchMethodException: injectInputEvent (fixes #2250) #2946

Closed
wants to merge 1 commit into from

Conversation

thomasrebele
Copy link
Contributor

No description provided.

rom1v pushed a commit that referenced this pull request Jan 16, 2022
Some devices with modified ROMs expose a different signature for
injectInputEvent().

Fixes #2250 <#2250>
PR #2946 <#2946>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Jan 16, 2022

Thank you 👍

I rebased onto dev (without conflicts) and changed minor things for consistency with other wrappers: pr2946

I also removed the "candidates" part, we don't do that for the other wrappers (and sometimes, it's not only a parameter change, for example here). It might be useful to add a global mechanism in verbose mode to expose the method list (if it is not too intrusive), but not at the same time as adding a specific fallback.

Could you review/test before I merge into dev, please?

@thomasrebele
Copy link
Contributor Author

Thanks for the cleanup. Indeed, it would make more sense to make the candidates code more general and apply it to all getMethod(...) calls.

The commit pr2946 looks good to me and works as expected.

rom1v pushed a commit that referenced this pull request Jan 18, 2022
Some devices with modified ROMs expose a different signature for
injectInputEvent().

Fixes #2250 <#2250>
PR #2946 <#2946>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Jan 18, 2022

👍 Merged b7a0627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants