Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation of the README.md #3023

Closed
wants to merge 1 commit into from

Conversation

Firq-ow
Copy link
Contributor

@Firq-ow Firq-ow commented Feb 14, 2022

Status:

  • Translated README.md to German (new file: README.de.md)
  • Links in README.de.md are all working to my knowledge
  • Proofreading by another person would be highly appreciated
  • A reference from README.md is not yet included
  • Maybe check if any of the german chars break anything (ä, ö, ü, ß)

On that note:
My german example with scrcpy --window-title "Mein Gerät" results in an awkward title (see image below)

image

This isn't a mayor issue, as scrcpy continues to work normally without errors.

Also, thank you all for providing this awesome application. Keep it up :)

Translated README.md to German (file: README.de.md).

Links in README.de.md are working to my knowledge.

Proofreading by another person would be highly appreciated.

A reference from README.md is not yet included.
@rom1v
Copy link
Collaborator

rom1v commented Feb 15, 2022

Thank you 👍

I added a commit (that I will squash before merging) to:

  • fix some spacing issues
  • reference the Windows release from the main README (so that it always points to the latest version)
  • removed the "translations" section from README.de.md (we can't keep up to date the translations versions/links from all translations)
  • added the link to the German translation from the main README

Branch: pr3023

Could you review it, please? Is it ok to you?

My german example with scrcpy --window-title "Mein Gerät" results in an awkward title (see image below)

There is an issue for this bug on Windows: #2932

rom1v pushed a commit that referenced this pull request Feb 15, 2022
PR #3023 <#3023>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Feb 15, 2022
PR #3023 <#3023>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Feb 15, 2022

Merged into master: b58b566

Thank you 👍

@rom1v rom1v closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants