Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README & Ln.java comment #3065

Closed
wants to merge 21 commits into from
Closed

Conversation

unique-EJ
Copy link
Contributor

@unique-EJ unique-EJ commented Feb 25, 2022

  • ### Summary
  • ## Custom paths
    ...

#3063

README.md#:~:text=Get%20the%20app,-Summary
README.md Outdated

## Custom paths

(Linux): For Android Studio (SDK) `adb` to be `adb` command, do `sudo ln --symbolic ### /usr/local/bin/adb`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3063 .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right place to explain this (it is independent of scrcpy).

Either you use the default adb (wherever it comes from in your PATH), either you can overwrite it using the ADB environment variable.

rom1v pushed a commit that referenced this pull request Mar 6, 2022
PR #3065 <#3065>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Mar 6, 2022
PR #3065 <#3065>

Signed-off-by: Romain Vimont <rom@rom1v.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

## Custom paths

(Linux): For Android Studio (SDK) `adb` to be `adb` command, do `sudo ln --symbolic ### /usr/local/bin/adb`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right place to explain this (it is independent of scrcpy).

Either you use the default adb (wherever it comes from in your PATH), either you can overwrite it using the ADB environment variable.

README.md Outdated
@@ -1105,10 +1086,7 @@ See [BUILD].

## Common issues

See the [FAQ].md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

ef24690 (not merged yet)

Copy link
Contributor Author

@unique-EJ unique-EJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good? Do more? @rom1v

README.md Outdated


## Run

Plug an Android device, and execute:
Plug in an Android device, **connect with [`adb`](https://developer.android.com/studio/command-line/adb)** and execute:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good?

* do `sudo ln --symbolic ### /usr/local/bin/adb` for Android Studio `adb` to be `adb` command.
* Update README.md

* Update README.md

* Update README.md

* do `sudo ln --symbolic ### /usr/local/bin/adb` for Android Studio `adb` to be `adb` command.
rom1v pushed a commit that referenced this pull request Apr 10, 2022
PR #3065 <#3065>

Signed-off-by: Romain Vimont <rom@rom1v.com>
brunoais pushed a commit to brunoais/scrcpy that referenced this pull request Apr 16, 2022
PR Genymobile#3065 <Genymobile#3065>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@unique-EJ unique-EJ changed the title Update README.md Update README & Ln.java comment Jun 2, 2022
@unique-EJ unique-EJ closed this Aug 29, 2022
@unique-EJ unique-EJ deleted the patch-1 branch September 4, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants