Add -s auto-complete option #3523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -s auto-complete option.
rom1v
reviewed
Oct 7, 2022
app/data/bash-completion/scrcpy
Outdated
| @@ -93,6 +93,11 @@ _scrcpy() { | |||
| COMPREPLY=($(compgen -W 'verbose debug info warn error' -- "$cur")) | |||
| return | |||
| ;; | |||
| -s|--serial) | |||
| # Use 'adb devices' to list serial numbers. | |||
| COMPREPLY=($(compgen -W "$(adb devices | awk '/(device|recovery|sideload)$/{print $1}')" -- ${cur} ) ) | |||
There was a problem hiding this comment.
I think that scrcpy may not work in recovery or sideload state, so maybe adb devices |awk '/device$/{print $1}' is sufficient.
since scrcpy don't work in sideload and recovery options, I've removed them.
rom1v
reviewed
Oct 7, 2022
| @@ -95,7 +95,7 @@ _scrcpy() { | |||
| ;; | |||
| -s|--serial) | |||
| # Use 'adb devices' to list serial numbers. | |||
| COMPREPLY=($(compgen -W "$(adb devices | awk '/(device|recovery|sideload)$/{print $1}')" -- ${cur} ) ) | |||
| COMPREPLY=($(compgen -W "$(adb devices | awk '/device$/{print $1}')" -- ${cur} ) ) | |||
There was a problem hiding this comment.
Also, if the ADB environment variable is set, this adb should be used instead.
"${ADB:-adb}" devices | awk …
rom1v
pushed a commit
that referenced
this pull request
Oct 7, 2022
Add -s autocompletion for zsh
|
Ok. I've added a similar solution to the zsh completion. :) |
rom1v
pushed a commit
that referenced
this pull request
Oct 12, 2022
rom1v
pushed a commit
that referenced
this pull request
Oct 12, 2022
rom1v
pushed a commit
that referenced
this pull request
Oct 12, 2022
|
Thank you 👍 I rebased your commits onto
I pushed to branch |
|
Checked. Many thanks 👍 :) |
|
Thanks 👍 Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -s auto-complete option.
Commented at the following issue: #3522