Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion syntax #4532

Closed
wants to merge 2 commits into from
Closed

Fix bash completion syntax #4532

wants to merge 2 commits into from

Conversation

msfjarvis
Copy link
Contributor

When the --orientation flag was introduced here the bash-completion file also gained a syntax error which breaks completions.

@msfjarvis
Copy link
Contributor Author

Spotted an additional bug with the completions of a couple options where rather than suggest options it would simply generate a file on disk with the entire options list as its name, I've also fixed that to align with the rest of the completions script.

rom1v pushed a commit that referenced this pull request Dec 14, 2023
PR #4532 <#4532>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Dec 14, 2023
PR #4532 <#4532>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Dec 14, 2023

Thank you 👍

Merged into dev:

@rom1v rom1v closed this Dec 14, 2023
@msfjarvis msfjarvis deleted the hs/fix-completion branch December 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants