Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table - stack: problem with edit variable properties #1810

Closed
lanselin opened this issue Feb 8, 2019 · 2 comments
Closed

Table - stack: problem with edit variable properties #1810

lanselin opened this issue Feb 8, 2019 · 2 comments
Assignees
@lixun910
Labels
fixed: verify! Module-Table

Comments

@lanselin
Copy link
Collaborator

lanselin commented Feb 8, 2019

It seems that something is wrong with the edit variable properties functionality after two tables have been stacked. Here is what I did. 1. edit variable properties to set number of decimals for "value" to 2 in table1; 2. do same in table2; 3. stack table1 and table2.

In the new stacked table, the number of decimals is 15 or something, even though in the edit variable properties it is given as 2 (see screen shot). It is possible to adjust the number of decimals in the stacked table, but first they need to be changed to a different number, e.g., 3, and then they can be changed back to 2. But initially, there is a mismatch with what is shown in the table and listed in the edit variable properties dialog.

screen shot 2019-02-07 at 4 25 48 pm
lixun910 added a commit to lixun910/geoda that referenced this issue Feb 8, 2019
@lixun910
GeoDaCenter#1810 table stack: problem with edit variable properties
3954079
@lixun910 lixun910 mentioned this issue Feb 21, 2019
Merged
@Ashitacarl
Copy link

GeoDa 1.12.1.201 (macOS Mojave, 10.14.3). Feb. 20 build.

Fix verified. Now stacking tables (point data) does not produce mismatch of actual and displayed decimal degrees.

However, when I tried to stack csv tables (no geometry), GeoDa warns me that line data is not supported. See below.

1810-2

lixun910 added a commit to lixun910/geoda that referenced this issue Feb 23, 2019
@lixun910
GeoDaCenter#1810 stack shapefile with csv report warning
ab36537 
For stack function, there are two cases:
1. working dataset is table-only, can be stacked with both table-only dataset and dataset with geometry features.
2. working dataset has geometry features, can only be stacked with dataset with geometry features. Also, the geometrical type (e.g. point/polygon/line) should be the same.
All other cases should raise warning message and cancel stack operation.

GeoDaCenter#1809 there is "title" in "selection tool" dialog not translated
@jkoschinsky jkoschinsky reopened this Mar 1, 2019
lixun910 added a commit to lixun910/geoda that referenced this issue Mar 5, 2019
@lixun910
GeoDaCenter#1810 update variable properties (displayed decimal places)
95ab5a4 
1. add item "Default displayed decimal places" in preference dialog, so users can configure the default displayed decimal places.
2. let GeoDa project file overwrite the "default displayed decimal places", so that user can always preserve different displayed decimals fro different variables(columns)
@Ashitacarl
Copy link

GeoDa 1.12.1.211 (macOS Mojave, 10.14.3). Mar. 18 build.

Fix verified. Stacking csv tables does not produce the geometry error mentioned above.

@lixun910 lixun910 mentioned this issue May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixun910 lixun910

Labels
fixed: verify! Module-Table
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lixun910 @lanselin @jkoschinsky @Ashitacarl