Feature/only net standard20 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2021 21:24
… it makes sense to run the release from the same platform as the tests
added 3 commits
December 27, 2021 21:50
…delines of specified version
…mmendations in the GeoJSON.Text project
MartinCarpentier
force-pushed
the
feature/only-net-standard20
branch
from
08d3863 to
0dfb25c
Compare
|
I have no problem with you having a mention in this package, create a PR 👍 |
|
Cool! 👍 |
matt-lethargic
approved these changes
Dec 31, 2021
|
Where would you like the mention? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed GeoJSON.Text project, so that it's built using only .NET Standard 2.0, since it seems to have full System.Text.Json support and therefore makes direct .NET version targeting redundant.
Changed the windows runner version to specific version instead of latest, to ensure stability.
Also changed the release and benchmark actions to run from windows, since we have to run build and tests on windows to use NET 4.6.2, and it therefore makes sense to run the actions on windows as well.
Also added the static code analyzer nuget package, and updated the code in regards to the generated messages.
Though only in regards to the GeoJSON.Text project.
PS
Since I did rewrite the entire GeoJSON.NET package to support System.Text.Json, It would be very nice to have a little mention on this package.