-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy2 support #290
Add numpy2 support #290
Conversation
Thanks Sebastian! 🙏 In order to ensure the wheels are compatible with NumPy 2, would recommend building with the NumPy 2 RC. The wheels built this way will work with NumPy 1 & 2 Just looking at the CI scripts, it appears these may be built with NumPy 1, which wouldn't be NumPy 2 compatible. Though please let me know if I've just missed something about how the builds work here |
Hey there, IMHO the wheels should be built with np 2rc. The important lines are in the pyproject.toml:
Since the wheels are built with cibuildwheel, these versions should be used. maybe you confused this with the versions in the testing matrix? |
Ah ok. Maybe I did. Thanks for the clarification Sebastian! 🙏 |
Since numpy 2 is around the corner (numpy/numpy#24300), we need to be prepared.
numpy 2.0rc1 is already available and can be used as a build time dependency, so we will use this to build our wheels in the CI.
I removed support for 32bit wheels and also removed the separately built universal2 wheels for macOS, since we already provide wheels for intel and arm64.