Don't Use Asserts For Runtime Errors #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pyshp is generally good about raising appropriate exceptions, it currently uses
assert()
in two places:Not only are these both examples of cases where
assert()
isn't appropriate, they're cases that could lead to data corruption if uncaught... and when CPython is invoked with -O or -OO,assert()
conditions are never raised.This patch raises a descriptive ShapefileException in these two cases.