docs(components): Convert another bundle to Storybook #1045
Conversation
Deploying with
|
| Latest commit: |
78068aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://475ad933.atlantis.pages.dev |
| Branch Preview URL: | https://job-62421-convert-mdx-bundle.atlantis.pages.dev |
| <Meta title="Components/LightBox" component={LightBox} /> | ||
|
|
||
| # Light Box | ||
|
|
There was a problem hiding this comment.
This seems to be missing the other styling when the lightbox is open
Storybook:
Docs currently:
There was a problem hiding this comment.
Also doesn't show on the canvas tab
There was a problem hiding this comment.
I knew I'd have nightmares with this
There was a problem hiding this comment.
This looks like an issue with the library react-image-lightbox, but it's already deprecated and it's been a while since the last update.
I tried upgrading it to 5.1.4 because they fixed this issue that is related to the lightbox being inside an iFrame (our case), but no success :(
There was a problem hiding this comment.
Are we able to use the library that is recommended instead?
https://www.npmjs.com/package/react-photoswipe-gallery
We may want to add it to our list of packages to upgrade because it is no longer maintained.
I feel like this should be a blocker but I will defer to @chris-at-jobber
There was a problem hiding this comment.
Yeah this is a pretty bad representation of the component and this will also impact viewers of Gallery as that component consumes Lightbox
There was a problem hiding this comment.
If we can split it out to solve independently and land the rest of these docs, that could be OK for now. Would really like InputText to be available 😄
There was a problem hiding this comment.
I removed LightBox from this PR so we can land the other ones.
There was a problem hiding this comment.
Overall looks good. I did notice that if I opened a link in a new tab it wouldn't work.
The url would be something like http://localhost:6005/iframe.html?path=/docs/components-inlinelabel--inline-label which doesn't seem to be correct.
I know storybook has a link addon that may solve this.
Since we have the follow up subtask I don't think this is a blocker for this PR
https://storybook.js.org/addons/@storybook/addon-links
|
It may also be related to the format of the links seen here: https://storybook.js.org/docs/react/writing-docs/mdx#linking-to-other-stories-and-pages |
|
@MichaelParadis I'll handle the links in another PR. Thanks! |
Motivations
Convert the first bundle of components to Storybook.
Changes
Added
Storybook pages for:
Changed
Deprecated
Removed
Fixed
Security
Testing
In Atlantis we use Github's built in pull request reviews.