Support extensions on operations #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2022
fisx
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
thanks!
works in the wire messenger, and the changes look good to me, but i'm not an active maintainer of this project, so i'd appreciate a second opinion.
(are there active maintainers?)
|
@isovector maybe you could add a haddocks description like in the other fields?
|
swamp-agr
approved these changes
Feb 4, 2023
fisx
added a commit
to wireapp/wire-server
that referenced
this pull request
Feb 4, 2023
GetShopTV/swagger2#245 has been merged.
fisx
added a commit
to wireapp/wire-server
that referenced
this pull request
Feb 4, 2023
GetShopTV/swagger2#245 has been merged.
battermann
pushed a commit
to wireapp/wire-server
that referenced
this pull request
Mar 8, 2023
GetShopTV/swagger2#245 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
_operationExtensionsfield toOperation, which correctly roundtrip.