Skip to content

Conversation

JcMinarro
Copy link
Contributor

🎯 Goal

When a new token come from FirebaseMessageService we were removing the providerName from the device, what could cause errors on our PN Logic.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

@JcMinarro JcMinarro requested review from adasiewiczr and a team November 2, 2022 14:45
@JcMinarro JcMinarro requested a review from a team as a code owner November 2, 2022 16:23
@JcMinarro JcMinarro merged commit b5e9b47 into v5 Nov 2, 2022
@JcMinarro JcMinarro deleted the hotfix/push-notification-delegates branch November 2, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants