CRNS-352: Unread counts and muted channels #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnarkhede
changed the title
|
Size Change: +778 B (0%) Total Size: 228 kB
|
vishalnarkhede
force-pushed
the
vishal/muted-channels
branch
from
d474bc2 to
5d43b0b
Compare
vishalnarkhede
force-pushed
the
vishal/muted-channels
branch
from
5d43b0b to
bcea475
Compare
vishalnarkhede
commented
May 13, 2021
src/client.ts
Outdated
| * | ||
| * @param cid | ||
| */ | ||
| channelMuteStatus = (cid: string) => this._muteStatus(cid).muted; |
There was a problem hiding this comment.
we have a similar function for userMuteStatus, so makes sense to have one for channel as well!!
vishalnarkhede
force-pushed
the
vishal/muted-channels
branch
from
de8409a to
e988761
Compare
DanC5
reviewed
May 13, 2021
vishalnarkhede
force-pushed
the
vishal/muted-channels
branch
from
aee6f35 to
7736613
Compare
vishalnarkhede
changed the title
vishalnarkhede
force-pushed
the
vishal/muted-channels
branch
from
bcf08e6 to
ac6cf04
Compare
mahboubii
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
https://getstream.slack.com/archives/C0185U214TF/p1620718706190100
We didn't consider muted channels while incrementing unread count, when new message comes in. We shouldn't increase unread count if channel is muted.