feat: optionally override TextInput inside AutoCompleteInput completely using props #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
isekovanic
approved these changes
Aug 20, 2025
isekovanic
reviewed
Aug 20, 2025
| ); | ||
|
|
||
| if (TextInputComponent) { | ||
| return <TextInputComponent {...rest} />; |
There was a problem hiding this comment.
Please make sure the passed props are the same here, so that the overidden component can be used directly and integrators can decide what to keep and what to remove. Otherwise, stuff like autoFocus, multiline and what not will break (and so will our UI).
isekovanic
requested changes
Aug 20, 2025
isekovanic
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to optionally override the
Textinputcomponent inside theAutoCompleteInputcomponent using a component prop to theMessageInputcomponent.Note: Also changed the deprecated types to the useful ones.