fix: remove inverted list android workaround #3199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
isekovanic
approved these changes
Aug 22, 2025
oliverlaz
reviewed
Aug 22, 2025
| ), | ||
| [shouldApplyAndroidWorkaround, FooterComponent], | ||
| ); | ||
| const ListFooterComponent = useCallback(() => <FooterComponent />, [FooterComponent]); |
There was a problem hiding this comment.
Do we have to wrap these components in useCallback()?
I'm pretty sure that
const ListFooterComponent = FooterComponent;will work the same, and would be more performant too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in earlier RN versions, we needed to implement a workaround for Android regarding inversions of the FlatList.
It boils down to this value here.
Since starting with V8 we are supporting only version 0.73.0 of React Native and onwards, we are finally safe to remove this.
It should prove to be a minor performance boost on Android.