Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing voice attachments #2943

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix editing voice attachments #2943

merged 2 commits into from
Dec 20, 2023

Conversation

martinmitrevski
Copy link
Contributor

🎯 Goal

Messages with async voice attachment weren't edited properly - we treated the voice recording as video recording.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@martinmitrevski martinmitrevski requested a review from a team as a code owner December 20, 2023 09:27
Copy link

github-actions bot commented Dec 20, 2023

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@martinmitrevski martinmitrevski merged commit 9ddaa51 into develop Dec 20, 2023
7 checks passed
@martinmitrevski martinmitrevski deleted the edit-async-voice branch December 20, 2023 11:27
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants