Fix jumping to bottom when loading new messages #2945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/682
🎯 Goal
Fix the message list jumping to the bottom when loading new messages.
Before, whenever the newest message inserted was from the current user, we would scroll to the bottom. This is incorrect, since when loading new messages, if the last message author, is the current user, it will scroll to it. Now, it will only scroll if there is one insertion, which is what happens when the current user creates a new message.
🧪 Manual Testing Notes
Note: The difference is not very noticeable sometimes. This issue also fixes another case where sometimes if a channel was opened and then quickly scrolling to the top, would unwillingly scroll to the bottom.
☑️ Contributor Checklist