Fix quoted chat message view with wrong text #2946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/683
🎯 Goal
Fix quoted chat message view with wrong text.
The quoted chat message was using the
textView.text.isEmpty
to determine how to render text. Since this is used in a reusable cell, it would sometimes reproduce unexpected results.🧪 Manual Testing Notes
This one was a bit hard to reproduce since it only happens when the cell is reused.
Either way, we have plenty of snapshot testing covering the quoted messages. If the tests are green, it should not have any regressions.
☑️ Contributor Checklist