Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoted chat message view with wrong text #2946

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Dec 20, 2023

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/683

🎯 Goal

Fix quoted chat message view with wrong text.

The quoted chat message was using the textView.text.isEmpty to determine how to render text. Since this is used in a reusable cell, it would sometimes reproduce unexpected results.

🧪 Manual Testing Notes

This one was a bit hard to reproduce since it only happens when the cell is reused.
Either way, we have plenty of snapshot testing covering the quoted messages. If the tests are green, it should not have any regressions.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

47 New issues
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Dec 21, 2023
@nuno-vieira nuno-vieira marked this pull request as ready for review December 21, 2023 00:06
@nuno-vieira nuno-vieira requested a review from a team as a code owner December 21, 2023 00:06
@nuno-vieira
Copy link
Member Author

Merging, since the failing test is flaky

@nuno-vieira nuno-vieira merged commit 44f5477 into develop Dec 21, 2023
14 of 15 checks passed
@nuno-vieira nuno-vieira deleted the fix/quoted-message-wrong-text branch December 21, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants