Remove type cast to integer #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identifiers are being casted into integers. This will cause problems for people that are using UUID's.
|
Not sure why tests are failing. I forked the repository and used it in my application. Issue seems to be resolved for me now. |
|
The reason for the change seems reasonable. I think the reason the tests fail is because the they have integers as ids. Could you change the pull request to use this and see if your application still works: try:
f_id = int(f_id)
except ValueError:
pass |
|
I now did this, as well as converting uuids to UUID objects in #55, so i'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiers are being type casted into integers. This will cause problems for people that are using UUID's.