Support django 2.0 #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package's setup.py specifies a range dependency on Django <=2.1.0 however Django 2.0 doesn't run on py 2.7. Travis build should install the configured version of Django prior to installing the stream-django package.
tbarbugli
reviewed
Dec 22, 2017
| - travis_retry pip install python-coveralls | ||
| - travis_retry pip install -e . | ||
| - travis_retry pip install $DJANGO --upgrade | ||
| - travis_retry pip install -e . |
There was a problem hiding this comment.
you should revert the order, Django version needs to be forced
|
Merged manually by @tbarbugli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to re-order the travis installation steps so it would pick up the Django version specific to the build matrix and not the highest Django version supported by the setup.py dependency.
The previous ordering seems a little strange to me so perhaps I'm overlooking something.
The previous travis build on the branch shows we're the problem manifests.
Closes #72 #71 #70 #69.