Skip to content

Better exception #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

Better exception #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3303bef
preserve exception stacktrace
tbarbugli Oct 8, 2025
c1dfd6f
fix import
tbarbugli Oct 8, 2025
8fae00f
Merge branch 'main' into better-exception
tbarbugli Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions getstream/video/rtc/connection_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,12 +329,12 @@ async def _connect_internal(
sfu_event.join_response.fast_reconnect_deadline_seconds
)
else:
logger.warning(f"No join response from WebSocket: {sfu_event}")
logger.exception(f"No join response from WebSocket: {sfu_event}")

logger.debug(f"WebSocket connected successfully to {ws_url}")
except Exception as e:
logger.error(f"Failed to connect WebSocket to {ws_url}: {e}")
raise SfuConnectionError(f"WebSocket connection failed: {e}")
logger.exception(f"Failed to connect WebSocket to {ws_url}: {e}")
raise SfuConnectionError(f"WebSocket connection failed: {e}") from e

# Step 5: Create SFU signaling client
twirp_server_url = self.join_response.data.credentials.server.url
Expand Down
5 changes: 4 additions & 1 deletion getstream/video/rtc/connection_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ async def create_join_request(token: str, session_id: str) -> events_pb2.JoinReq
A JoinRequest protobuf message configured with data
"""

from video.rtc.pc import subscribe_codec_preferences, publish_codec_preferences
from getstream.video.rtc.pc import (
subscribe_codec_preferences,
publish_codec_preferences,
)

# Create a JoinRequest
join_request = events_pb2.JoinRequest()
Expand Down
Loading