Fix discarding of custom trim patterns/materials #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebeastchris
approved these changes
May 6, 2024
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
* Fix discarding of custom trim patterns/materials * Rename `stripNamespace` method to reflect its behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes discarding of custom trim patterns/materials by checking for the namespace of the trim pattern/material and discarding it if the namespace is not
minecraft.Previously, the
Holder#isCustommethod was used, but this doesn't work since the Minecraft server sends the trim patterns and materials registries to the client and then sends holders with int IDs instead of direct objects.Note: I added a
getNamespace(String identifier)method to theArmorItemclass. I'm not sure if there's already a similar method available, or if there's a better class it should go in, please do let me know.