ACM-20531, ACM-20534, ACM-20718 - Create UI for RBAC for VMs - View, Edit and Create functionality #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oksanabaza
changed the title
oksanabaza
changed the title
mshort55
reviewed
May 15, 2025
oksanabaza
changed the title
…Edit and Create functionality Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
mshort55
reviewed
May 15, 2025
| </DescriptionListGroup> | ||
| ) | ||
| } | ||
| case 'Radio':{ |
There was a problem hiding this comment.
Is it possible to refactor to not have this duplicate code in lines 920-937 and 1268-1286?
Ginxo
reviewed
May 19, 2025
| }, [accessControl?.metadata]) | ||
|
|
||
| useEffect(() => { | ||
| if (!isEditing && !isViewing && selectedUsers.length === 0) { |
There was a problem hiding this comment.
> !selectedUsers.length ? 'true' : 'false'
'true'
> selectedUsers.length === 0 ? 'true' : 'false'
'true'
so 🤔
if (!isEditing && !isViewing && !selectedUsers.length) {
Ginxo
reviewed
May 19, 2025
| const renderLabelGroup = () => { | ||
| return ( | ||
| <LabelGroup isVertical numLabels={labels.length} expandedText={expandedText} collapsedText={collapsedText}> | ||
| <LabelGroup isVertical={props.isVertical ?? true} numLabels={labels.length} expandedText={expandedText} collapsedText={collapsedText}> |
There was a problem hiding this comment.
right? 🤔
isVertical={props.isVertical}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Ticket Summary (Title):
Create View, Edit and Create pages to support the RBAC for VMs functionality
Ticket Link:
https://issues.redhat.com/browse/ACM-20531
https://issues.redhat.com/browse/ACM-20534
https://issues.redhat.com/browse/ACM-20718
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers