Latest merge from dependabot-core #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd deleted files in GitLab client
Add UpdateChecker test cases for a gem that depends on a particular version of bundler.
…dler2-resolution Bundler: Add tests for bundler 2 resolution
Currently in the CI container we bundle install for _every_ package, this ends up taking 4 to 5 minutes on every build for every ecosystem. Since the tests are split up per ecosystem, we only need to install the gems for the package that is being tested in this matrix step. This also introduces a `script/ci-test` per ecosystem, it currently runs both rubocop and rspec for all ecosystems, but the expectation is that these scripts might diverge per ecosystem. Running both rspec and rubocop in the same script is done to prevent us from having to `bundle install` for each of those steps. We could take this approach a step further and split out a CI container per ecosystem, and that would let us run rubocop and rspec as separate steps, but I don't think this is currently worth it. This should shave about 5 minutes of every matrix build.
Co-authored-by: Philip Harrison <philip@mailharrison.com>
This was only added because of the changes here dependabot#3279 which where reverted here dependabot#3320 This step sometimes takes over a minute.
CI: Only bundle install for ecosystem under test
…i-free-disk-step CI: Remove step freeing up disk space
We were setting up a bunch of conditional tests/linting in the workflow file, but now that we have test scripts I think it's cleaner to run those inline in the `script/ci-test` script
Co-authored-by: Philip Harrison <philip@mailharrison.com>
I hacked together a little script to figure out which python versions we're actually installing in our test suite, turns out it's not that many: dependabot@9f7251b But this leads to almost 10 minutes of time spent _every python run_. This change runs the install steps in the CI Dockerfile so they can be cached. It does nothing to prevent newer versions from python being added in new tests, but it's a fairly safe way to shave 10 minutes of the build.
…workflow CI: Simplify workflow by moving suite specific tests into test script
…python CI: Pre-install python versions used in tests
In dependabot#3431 we introduced some pre-installed versions of Python in an effort to speed up our test. @brrygrdn rightfully pointed out it'd be good to add a note as to why this is here. This is said note.
Bumps [@npmcli/arborist](https://github.com/npm/arborist) from 2.2.9 to 2.3.0. - [Release notes](https://github.com/npm/arborist/releases) - [Changelog](https://github.com/npm/arborist/blob/main/CHANGELOG.md) - [Commits](npm/arborist@v2.2.9...v2.3.0) Signed-off-by: dependabot[bot] <support@github.com>
This reverts commit d4f8c26.
…ld-bundler2-codepath Remove unused bundler v2 codepath
Bumps [poetry](https://github.com/python-poetry/poetry) from 1.1.4 to 1.1.6. - [Release notes](https://github.com/python-poetry/poetry/releases) - [Changelog](https://github.com/python-poetry/poetry/blob/1.1.6/CHANGELOG.md) - [Commits](python-poetry/poetry@1.1.4...1.1.6) Signed-off-by: dependabot[bot] <support@github.com>
Update setup cfg
…hon/helpers/poetry-1.1.6 build(deps): bump poetry from 1.1.4 to 1.1.6 in /python/helpers
…ditions dry-run: ignore conditions from env
…_suffix Refactoring new_branch_name function in branch_namer
GiriB
approved these changes
Apr 20, 2021
milind009
commented
Apr 20, 2021
| @@ -5,23 +5,33 @@ | |||
| module Dependabot | |||
| class DependencyFile | |||
| attr_accessor :name, :content, :directory, :type, :support_file, | |||
| :symlink_target, :content_encoding, :deleted | |||
| :symlink_target, :content_encoding, :operation | |||
There was a problem hiding this comment.
@GiriB we could make use of this change in our azure.rb class where add files in "edit"/ "add" mode depending if the files exists or not right?
There was a problem hiding this comment.
Yup. We should be able to. Will create a Task for this. If we do this change, then we can update this in dependabot/core altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes that are important to us -
branch_namer.rbwhich involves creating a separate method for getting theversion suffixfor a branch.