Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landmarks level tests [GSK-2348] #14

Merged
merged 17 commits into from
Jan 10, 2024

Conversation

pierlj
Copy link
Collaborator

@pierlj pierlj commented Dec 29, 2023

Added multiples metrics:

  • NEs: normalised euclidean distance
  • NERFMark: per landmark and per image test whether the prediction is within a given radius around the ground truth
  • NERFImagesMean: mean of NERFMark in the image dimension, i.e. per landmark failure rate given the radius average on all images.
  • NERFImagesStd: same as above for std.
  • NERFMarksMean: mean of NERFMark in the mark dimension, i.e. per image failure rate given the radius average on all marks.
  • NERFMarksStd: same as above for std
  • NERFImages: proportion of images that have at least failed_mark_ratio landmarks that are not inside the radius around the ground truth.

Added unit tests for these metrics.

Changed the location and name of _calculate_d_outers --> compute_d_outers now in loreal_poc/marks/utils.py.
Also changed a bit the drawing method to display mark with their radius (check ex_8_NERF_metric.ipynb to see an example).

Copy link

linear bot commented Dec 29, 2023

GSK-2348 New test on landmarks-level

pre-aggregation of NME: Number of landmarks allowed to not respecting the threshold (radius around the ground-truth)

Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise LGTM

loreal_poc/tests/performance.py Outdated Show resolved Hide resolved
loreal_poc/tests/performance.py Outdated Show resolved Hide resolved
loreal_poc/tests/performance.py Outdated Show resolved Hide resolved
tests/tests_and_metrics/test_metrics.py Outdated Show resolved Hide resolved
@pierlj pierlj force-pushed the GSK-2348-add-landmarks-level-tests branch from b57636c to 100377f Compare January 10, 2024 11:39
@rabah-khalek rabah-khalek merged commit 011b29b into main Jan 10, 2024
4 checks passed
@rabah-khalek rabah-khalek deleted the GSK-2348-add-landmarks-level-tests branch January 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants