-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landmarks level tests [GSK-2348] #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSK-2348 New test on landmarks-level
pre-aggregation of NME: Number of landmarks allowed to not respecting the threshold (radius around the ground-truth) |
rabah-khalek
suggested changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, otherwise LGTM
pierlj
force-pushed
the
GSK-2348-add-landmarks-level-tests
branch
from
January 10, 2024 11:39
b57636c
to
100377f
Compare
rabah-khalek
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multiples metrics:
failed_mark_ratio
landmarks that are not inside the radius around the ground truth.Added unit tests for these metrics.
Changed the location and name of
_calculate_d_outers
-->compute_d_outers
now inloreal_poc/marks/utils.py
.Also changed a bit the drawing method to display mark with their radius (check
ex_8_NERF_metric.ipynb
to see an example).