Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-3430] Check if we can detect the version of giskard library #1876

Conversation

Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Apr 4, 2024

Description

Extract extra package information using importlib_meta:

  • allows to set exact_deps in initialize_kernel to take all extra package information (but it could fail on managed side)
  • otherwise, we just add for our "giskard"

The output should be:

giskard[hub, llm]==2.8.0

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@Inokinoki Inokinoki merged commit af17630 into multi-ml-worker Apr 5, 2024
15 of 16 checks passed
@Inokinoki Inokinoki deleted the feature/gsk-3430-check-if-we-can-detect-the-version-of-giskard-library branch April 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants