Skip to content

Issue 220 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2017
Merged

Issue 220 #223

merged 2 commits into from
Aug 3, 2017

Conversation

fbourigault
Copy link
Contributor

This fix the Gitlab\Api\AbstractApi delete and put methods. delete parameters are used as query string parameters and put parameters are encoded as request body using the application/x-www-form-urlencoded content type. This also remove the unused patch method.

This fix #220.

@fbourigault fbourigault added this to the v4 milestone Aug 1, 2017
@fbourigault
Copy link
Contributor Author

Thank you for review!

@fbourigault fbourigault merged commit 9886de2 into GitLabPHP:master Aug 3, 2017
@fbourigault fbourigault deleted the issue-220 branch August 3, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1guelpf m1guelpf m1guelpf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The server does not see the parameters passed in the request body (Updated)
2 participants
@fbourigault @m1guelpf