[9.18] Adding a single group membership endpoint #490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1guelpf
requested changes
Apr 15, 2020
glensc
reviewed
May 1, 2020
| { | ||
| $resolver = $this->createOptionsResolver(); | ||
| $resolver->setDefined('query'); | ||
|
|
There was a problem hiding this comment.
$resolver is unused, too much copy-pasting and not testing your added functionality?
I personally would add @see annotation and link to api doc, so could verify what parameters are supported
GrahamCampbell
changed the title
|
Thanks for starting work on this @dzink. Are you able to finish off this PR please? |
GrahamCampbell
changed the title
GrahamCampbell
changed the title
|
Thanks for this. I've finished this off now. Note that we've already implemented this on the projects API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project
This only implements this function for groups.