Skip to content

[11.1] Add order_by and sort params support to Deployments::all() #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2021

Conversation

b1rdex
Copy link
Contributor

@b1rdex b1rdex commented Jan 15, 2021

No description provided.

@GrahamCampbell GrahamCampbell changed the title Add order_by and sort params support to Deployments::all() [11.1] Add order_by and sort params support to Deployments::all() Jan 15, 2021
@GrahamCampbell GrahamCampbell changed the base branch from 11.0 to 11.1 January 15, 2021 12:51
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jan 15, 2021

Thanks for this. Could you:

  • Rebase against 11.1
  • Add a couple of tests
  • Add an entry to the change log (which is what requires you to rebase)

@b1rdex
Copy link
Contributor Author

b1rdex commented Jan 15, 2021

What kind of tests am I supposed to write? Would be nice to see an example.

@GrahamCampbell
Copy link
Member

Please look at the existing tests. :)

@GrahamCampbell
Copy link
Member

https://github.com/GitLabPHP/Client/pull/615/files would be a helpful example of doing exactly this.

@b1rdex
Copy link
Contributor Author

b1rdex commented Jan 17, 2021

@GrahamCampbell done

@GrahamCampbell GrahamCampbell merged commit bf3056c into GitLabPHP:11.1 Jan 17, 2021
@GrahamCampbell
Copy link
Member

Excellent, thanks.

@b1rdex b1rdex deleted the patch-1 branch January 17, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants