Skip to content

[11.8] Allow specifying params for Wiki::showAll() #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[11.8] Allow specifying params for Wiki::showAll() #670

wants to merge 2 commits into from

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Nov 5, 2021

@GrahamCampbell
Copy link
Member

You should use the result pager to fetch different pages, assuming that is your use case here.

@spawnia
Copy link
Contributor Author

spawnia commented Nov 5, 2021

Thanks for the hint, I will definitely keep that in mind as we probably have some wikis with over 20 pages 👍

@spawnia
Copy link
Contributor Author

spawnia commented Nov 5, 2021

Passing the option is still useful though:

        $pages = (new ResultPager($this->gitlab->connection()))->fetchAll(
            $this->gitlab->wiki(),
            'showAll',
            [
                $projectId,
                ['with_contents' => true]
            ],
        );

@spawnia
Copy link
Contributor Author

spawnia commented Nov 9, 2021

Is there anything else I can do here? Would love to see this merged, I am currently blocked by being unable to use the GitLab API to its full extent.

@GrahamCampbell GrahamCampbell changed the title Allow specifying params for Wiki::showAll() [11.6] Allow specifying params for Wiki::showAll() Dec 26, 2021
@GrahamCampbell GrahamCampbell changed the base branch from 11.4 to 11.5 December 26, 2021 15:57
@GrahamCampbell GrahamCampbell changed the base branch from 11.5 to 11.6 December 26, 2021 23:32
@spawnia
Copy link
Contributor Author

spawnia commented Dec 27, 2021

I don't know what to do about the test failure, tests against the local PHP 7.4 setup (using make) work.

@GrahamCampbell GrahamCampbell changed the title [11.6] Allow specifying params for Wiki::showAll() [11.7] Allow specifying params for Wiki::showAll() Jan 23, 2022
@GrahamCampbell GrahamCampbell changed the base branch from 11.6 to 11.8 January 24, 2022 03:30
@GrahamCampbell GrahamCampbell changed the title [11.7] Allow specifying params for Wiki::showAll() [11.8] Allow specifying params for Wiki::showAll() Jan 24, 2022
@GrahamCampbell
Copy link
Member

I was unable to push to your branch because you unchecked the option. I'm going to re-create this PR.

@GrahamCampbell
Copy link
Member

Thanks for the PR. :)

@spawnia spawnia deleted the wiki-show-all-params branch February 14, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants