Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

How about a new release? #907

Closed
18 tasks done
GitSquared opened this issue Nov 20, 2020 · 17 comments
Closed
18 tasks done

How about a new release? #907

GitSquared opened this issue Nov 20, 2020 · 17 comments

Comments

@GitSquared
Copy link
Owner

GitSquared commented Nov 20, 2020 •
edited
Loading

On May 19, 2019 I released v2.2.2, an emergency release branched out from what was already supposed to be v3, to patch a security issue.

Life happened, and I never got around to finishing the remote monitoring feature that was supposed to be the key change in v3... And now we're in this weird situation where the latest release is unsupported and everyone interested has to go run the thing from source. And the diff is only growing...

image

The situation as described in #769 hasn't changed, but, out of respect for the 20+ contributors who've contributed a patch since the latest release and the 30k unique monthly visitors to this repository... I'm starting to think I should release a v2.2.3.

Any thoughts on this?

(Pinging some recent contributors and active commenters: @Animus-Surge @wrac4242 @lebarde )

New release to-do list:

  • Explore the diff and draft a changelog - thanks a lot to @lebarde!
    • List all contributors since v2.2.2 
       Surge, qsniyg, wrac4242, D4rkia, Bodo Graumann, Emir Sarı, Freddie Runnding, Ivan Torres Fally, Jabster28, Le Barde, Maxim Mazurok, Michael de Silva, Nikhil, Niklas Arndt, Val, shine, theunbound, timescam
    • Confirm new version number (patch or minor?) Patch!
  • Repair the CI pipeline (or build a new one?) - See 👷 Feat: Replace Travis w/ GitHub Actions CI #912 - thanks @Jabster28 !
  • Get packaged assets for all platforms
    • linux32 (maybe scrap this one?)
    • linux64
    • macOS (check Big Sur compat...) Can't support apple silicon yet.
    • win32_64
    • linux_arm?
  • Write release notes draft
  • Tag & Release
  • Release AUR package
  • Update README
    • Direct download links
    • Q&A, notably the part about ARM
  • Update project status pinned issue
  • Set master package version back to v3.0.0-pre
@lebarde
Copy link
Contributor

lebarde commented Nov 20, 2020

Indeed that would make a lot of relevant changes, especially for users that take the Appimages.

@wrac4242
Copy link
Contributor

I agree that there should be a new release soon

Repository owner deleted a comment from razaamir Nov 20, 2020
@Animus-Surge
Copy link
Contributor

Animus-Surge commented Nov 20, 2020 •
edited
Loading

Yeah, definitely a good idea to do one soon, especially with the fixes and features that have been added/updated since v2.2.2

EDIT: Maybe perhaps it could be v2.3, as it's not major enough to make it v3.0.0, but not small enough to count as a maintenance release. Just a thought though

@parkerlreed
Copy link

At the very least it will squash a ton of bug reports that only tested against 2.2.2 :)

@GitSquared
Copy link
Owner Author

Maybe perhaps it could be v2.3, as it's not major enough to make it v3.0.0, but not small enough to count as a maintenance release. Just a thought though

I will need to dig into diff at some point but I don't think there is actually any new "feature", which is what the middle number has been used for on this repo so far.

I'll add a tasklist to this issue's desc so we can track what's needed before doing this.

@GitSquared
Copy link
Owner Author

Done. If anyone wants to help out, especially with the build targets stuff...

As for the changelog, I'll probably take a weekend off other projects and dig into it. I don't think the commit messages are sufficiently similar to automate this process - maybe i'll take the opportunity to install komit.

@lebarde
Copy link
Contributor

lebarde commented Nov 25, 2020 •
edited
Loading

Contributors

Thanks to git-shortlog, I list contributors from v2.2.2 to aef706c.

~/dev/edex-ui$ git shortlog -sne v2.2.2..HEAD

So after some cleaning to remove duplicates, here are the contributors by contributions: GitSquared, Surge, qsniyg, wrac4242, D4rkia, Bodo Graumann, Emir Sarı, Freddie Runnding, Ivan Torres Fally, Jabster28, Le Barde, Maxim Mazurok, Michael de Silva, Nikhil, Niklas Arndt, Val, shine, theunbound, timescam.

And best contributor: Dependabot with 129 contributions :-)

Changelog

Thanks to git-changelog, I was able to generate a changelog. Here it is: changelog_edex.txt

If I remove the bots' commits:

If that helps :-)

@GitSquared
Copy link
Owner Author

And best contributor: Dependabot with 129 contributions :-)

Wish GitHub had a way to separate bots and human contributors in the lists...

If that helps :-)

It does, thanks a lot!!

@Jabster28
Copy link
Contributor

On the topic of changelogs, if we were to use a commit standard such as conventional commits. we'd be able to use packages such as standard-version or release-please to automate changelogs and what not for releases

@GitSquared
Copy link
Owner Author

Indeed, I've been using conventional commits in more recent projects and even developed a commit message helper for it. I think we're going to transition this repo after this release, that'll be a good start for saner CI practices from now on.

@Jabster28
Copy link
Contributor

Jabster28 commented Nov 25, 2020 •
edited
Loading

Oh, komit looks cool!

Does it skip the prompt if you've already added a commit message? I don't think things like GitKraken or VSCode would work when committing otherwise.

@GitSquared
Copy link
Owner Author

No but you can just ctrl-c. It's pretty barebones, there's a lot of cool feats I could add to it but didn't find the time to. I also use Vim and git on the CLI so... I unfortunately don't have much experience with modern GUI workflows.

GitSquared added a commit that referenced this issue Nov 26, 2020
@GitSquared
enable Linux arm64 builds #313 #818 #907
4b688c7
GitSquared added a commit that referenced this issue Nov 26, 2020
@GitSquared
upgrade to Electron 11, attempt apple silicon build #907
ae5a420
@GitSquared
Copy link
Owner Author

GitSquared commented Nov 26, 2020 •
edited
Loading

I think we're going to forget the Apple M1 build for this one, as there are blocking upstream issues (microsoft/node-pty#441 ...) turns out it's electron 11 related so that's even worse.

GitSquared added a commit that referenced this issue Nov 26, 2020
@GitSquared
revert to electron 10 #907
f643b19
GitSquared added a commit that referenced this issue Nov 26, 2020
@GitSquared
tag v2.2.3 #907
60bfaf3
@GitSquared
Copy link
Owner Author

GitSquared commented Nov 26, 2020 •
edited
Loading

The release is ready but I'm waiting on more info about a security issue downstream, expected ETA tomorrow evening (CET).

GitSquared added a commit that referenced this issue Nov 27, 2020
@GitSquared
chore: upgrade systeminf to v4.30.5, patch sec issue #907
e8a36aa
@GitSquared
Copy link
Owner Author

And we're gold! Thanks to everyone involved. Will cleanup some stuff and close this, release will be up in a few minutes at https://github.com/GitSquared/edex-ui/releases/tag/v2.2.3

@Jabster28
Copy link
Contributor

Jabster28 commented Nov 27, 2020 •
edited
Loading

@GitSquared is the homebrew repo updated automatically? it still says v2.2.2 for me...

EDIT: No it isn't, I'll update it now.

@GitSquared
Copy link
Owner Author

Thanks! Forgot about this one. Homebrew/homebrew-cask#93788

@ThatGuySam ThatGuySam mentioned this issue Feb 3, 2021
Closed
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
@GitSquared @eugene2candy
enable Linux arm64 builds GitSquared#313 GitSquared#818 GitSquared#907
75197cf
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
@GitSquared @eugene2candy
upgrade to Electron 11, attempt apple silicon build GitSquared#907
7ac85cd
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
@GitSquared @eugene2candy
revert to electron 10 GitSquared#907
3350cdb
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
@GitSquared @eugene2candy
tag v2.2.3 GitSquared#907
e313ba8
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
@GitSquared @eugene2candy
chore: upgrade systeminf to v4.30.5, patch sec issue GitSquared#907
33e22bc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@parkerlreed @lebarde @Animus-Surge @GitSquared @Jabster28 @wrac4242