[Bug] ignore parameter does not ignore everything

[ibvhefe]

Describe the bug

1. Checkout the support branch of this project (Gitversion/support-branch)
2. Change the GitVersion.yml to

mode: Mainline
branches: {}
ignore:
  sha: [ ]
  commits-before: 2023-04-10T01:00:00 #some date in the future
merge-message-formats: {}

3. Run GitVersion

Expected Behavior

A version such as 0.1.0

Actual Behavior

The calculated version seems to be too high:

{
  "Major": 1,
  "Minor": 2,
  "Patch": 111
  ...
}

[asbjornu]

Although I don't see the value of this, I agree that ignoring the entire repository should yield a 0.1.0 version number. Pull requests are welcome.

[rominator1983]

I'm also in need of this and started a branch here https://github.com/rominator1983/GitVersion/tree/fix/IgnoreAllCommits_Issue3074 to make a PR

The value of this (at least that's what I hope) is to mitigate erroneous commits.
For example bit-bucket in its default configuration adds the latest 20 commit message of a source branch to a PR merge. This duplicates the "+semver:major" commit message which can't possibly be undone if you just see this some weeks later and there are several people on the project. 😦

I was wondering about the tests. I ran the tests 3 locally and got 21 (for tag 5.10.3) or 10 (main) red tests.
I was using Visual Studio 2022 and .net 6 as a runtime. I also installed .net core 3.1 since Visual Studio told me to do so. This unfortunately did not make any difference.

Here is an example of a broken test. NextVersionCalculatorTests.PreReleaseNumberShouldBeScopeToPreReleaseLabelInContinuousDelivery:

   Source: NextVersionCalculatorTests.cs line 279
   Duration: 1,1 sec

  Message: 
Shouldly.ShouldAssertException : variables.FullSemVer
    should be
"0.1.0-beta.1+2"
    but was
"0.1.0-beta.1+3"
    difference
Difference     |                                                                   |   
               |                                                                  \|/  
Index          | 0    1    2    3    4    5    6    7    8    9    10   11   12   13   
Expected Value | 0    .    1    .    0    -    b    e    t    a    .    1    +    2    
Actual Value   | 0    .    1    .    0    -    b    e    t    a    .    1    +    3    
Expected Code  | 48   46   49   46   48   45   98   101  116  97   46   49   43   50   
Actual Code    | 48   46   49   46   48   45   98   101  116  97   46   49   43   51   

  Stack Trace: 
GitToolsTestingExtensions.AssertFullSemver(RepositoryFixtureBase fixture, String fullSemver, Config configuration, IRepository repository, String commitId, Boolean onlyTrackedBranches, String targetBranch) line 116
NextVersionCalculatorTests.PreReleaseNumberShouldBeScopeToPreReleaseLabelInContinuousDelivery() line 308

Also I tried to run a documentation build as described in docs/readme.md but the command .\build.ps1 -Target Preview-Documentation gives me Error: The target 'Preview-Documentation' was not found.

So this makes it difficult for me to tell if my changes are fine or if existing tests need to be adapted because of a changed behavior.

[rominator1983]

@ibvhefe you think you could try if the PR fixes your issue?

[ibvhefe]

@rominator1983 thanks a lot for caring and providing a fix. Unfortunately I am on vacation and do not have access to a computer. I can try it out in two weeks. Sorry

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs.