Pulling version from IP in remote url

[igloo15]

I have a problem where GitVersion is pulling a version number from an ip in the url of the remote. This happens when GitVersion analyzes merge messages.

Here is a paste bin : http://pastebin.com/NFnFDk5i

I should be on version 2.0 but since the merge message is:
Merge branch 'DEMO' of http://10.10.10.121/gitlab/mtolland/orcid into DEMO

It grabs the IP and makes my version 10.11

[JakeGinnivan]

We have an open task at #538 which will allow issues like this to be fixed. We could also try and fix the regexes so ip addresses do not get recognised.

[igloo15]

While I think that task #538 will allow me to work around this issue I think that updating regexes to not consider IP addresses is better solution for this particular issue. I don't have alot of experience with Regexes but I will play around with it to see if I can find a regex that will not grab IP addresses.

[gep13]

While an addition to the regex to cover this case of an IP Address may address your issue, there are probably yet more edge cases like this that would need to be supported. A more general approach like ignoring commits before this date, or point in history, means that those edge cases don't need to be addressed.

[igloo15]

Yes I agree but maybe the regex could configurable at least because every merge request in this repo is going to have the ip address in the default merge message.

[gep13]

@JakeGinnivan I know we have some regex configurations available, but I don't think we have one to cover this situation, right?

[JakeGinnivan]

This is something I don't think should be configurable, it could cause issues which are difficult to debug.

I still think the ignore: configuration option is fine, we can just have contains: <ipaddress> which will automatically filter the merge commits with that ip address in it.

[igloo15]

I did not realize there would be an contains option on #538 I thought I was going to have to add an ignore sha to every commit that had an ip. If I can just ignore some text that would be just as good if not better.

[JakeGinnivan]

There wasn't :) But no reason not to have multiple ways to exclude things. I will start on #538 tomorrow if noone picks it up first

[mkoertgen]

I modified the involved regexp to filter out versions prefixed with '://', cf. #659.

This should fix this issue #557 as well.

[mkoertgen]

I added green testcases for #557 (comment) and #538 (comment) with commit 78b9837.

Anything missing for the pull request to be merged?

[mkoertgen]

This should be fixed with #661

[mkoertgen]

Can we close this issue, then?