Skip to content

Add the xml namespace to work with MSBuild v14 #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2018
Merged

Add the xml namespace to work with MSBuild v14 #1471

merged 2 commits into from
Oct 10, 2018

Conversation

jbaehr
Copy link
Contributor

@jbaehr jbaehr commented Sep 12, 2018

This fixes #1466

@dazinator
Copy link
Contributor

Thanks for this, sorry for the delay. Can't see any harm in merging this as its just a namespace addition, shouldn't break anything, builds and tests all look good, so merging.

@dazinator dazinator merged commit 8b1f6a3 into GitTools:master Oct 10, 2018
@jbaehr jbaehr mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitVersionTask 4.0.0-beta0014 does not work with MSBuild-14.0
2 participants
@jbaehr @dazinator