Ensure GetVersion runs prior to XAML's Markup Compiler #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XAML Markup Compiler (from PresentationBuildTasks via target "MarkupCompilePass1") generates C# code which loads the XAML at run time from a managed resource. This resource is identified by an URI, containing the assembly where the resource is embedded and the path towards it. Without the "AssemblyVersion" property being set, this URI contains only the simple assembly name, without version information. This works as long as the assembly is only loaded once. However, in e.g. advanced plugin scenarios it may happen that the same (strong named) assembly is loaded several times in different versions. In those cases the XAML resource can only be located when the version information is available in the URI. This fixes GitTools#1465.
|
@jbaehr - thanks for this, I've forward integrated and as long as the builds succeed and tests pass, I'll get this this one merged, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1465. Please find more details in the referenced issue.