Skip to content

Conversation

jakubsuchybio
Copy link
Contributor

@jakubsuchybio jakubsuchybio commented Oct 5, 2019

Making PR for @asbjornu after requesting it in #1825

This PR adds more information for users using GitVersion with TeamCity in MainLine mode.
By default, TeamCity doesn't work with MainLine, because TeamCity only downloads current building branch and not the master, so gitversion can't figure out the version.

After this PR I think there should also be some changes to the code where the errors occurs. So that these errors are descriptive about this new documentation and users can fix this issue for them without any more hassle.

For more reference about this issue see:
#912, #1199, #1234, #1441, #1477 and #1825

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks so much for this! I just have a few ideas for improvements.

jakubsuchybio and others added 3 commits October 5, 2019 11:54
Co-Authored-By: Asbjørn Ulsberg <asbjorn@ulsberg.no>
Co-Authored-By: Asbjørn Ulsberg <asbjorn@ulsberg.no>
@jakubsuchybio jakubsuchybio requested a review from asbjornu October 5, 2019 09:59
@asbjornu
Copy link
Member

asbjornu commented Oct 5, 2019

@arturcic, do you have any ideas why the build is failing on AZDO?

@arturcic
Copy link
Member

arturcic commented Oct 5, 2019

Fixed the build, you can merge @asbjornu

@asbjornu asbjornu merged commit 84b4af9 into GitTools:master Oct 5, 2019
@asbjornu
Copy link
Member

asbjornu commented Oct 5, 2019

Thanks for your contribution, @jakubsuchybio! 🙏

@arturcic arturcic added this to the 5.1.0 milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants