Support updating a single common AssemblyInfo.cs #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +43,19 @@ public AssemblyInfoFileUpdate(Arguments args, string workingDirectory, Dictionar | |||
| } | |||
| } | |||
|
|
|||
| static IEnumerable<string> GetAssemblyInfoFiles(string workingDirectory, Arguments args) | |||
| { | |||
| if (args.UpdateAssemblyInfoFileName != null) | |||
There was a problem hiding this comment.
Why not just return Directory.GetFiles(workingDirectory, args.UpdateAssemblyInfoFileName ?? "AssemblyInfo.cs", SearchOption.AllDirectories);
There was a problem hiding this comment.
Yeah, this could work, I also did the Path.GetFullPath to handle both relative and absolute paths...
Though it also might be useful to provide a relative root directory, e.g. update all assemblyinfo.cs under this specific dir (and not in the entire repository)
|
I think the args need to be added to the console help still as well |
JakeGinnivan
added a commit
that referenced
this pull request
Aug 8, 2014
Support updating a single common AssemblyInfo.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to support issue #224.
This adds support for specifying the filename as:
/updateassemblyinfo ..\src\CommonAssemblyInfo.csor/updateassemblyinfo "C:\src\CommonAssemblyInfo.cs".