Namespace name cannot start with numbers #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o on a project which file name starts with numbers will fail. This can happen when a project file starts with a number or when building a WPF project because the GenerateTemporaryTargetAssembly task will create a temporary project with a random name which can start with a number (see https://msdn.microsoft.com/en-us/library/bb397861.aspx). The fix removes numbers from the start of the assembly name
|
#574 fixes this issue by using RootNamespace instead. Thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the assembly info on a project which file name starts with numbers will fail or when building a WPF project because the GenerateTemporaryTargetAssembly task will create a temporary project with a random name which can occasionally start with a number (see https://msdn.microsoft.com/en-us/library/bb397861.aspx).
The fix removes numbers from the start of the assembly name