Skip to content

Conversation

asbjornu
Copy link
Member

Try to parse the next-version configuration value as a System.Int32 and treat the parsed value as the major version number.

@JakeGinnivan
Copy link
Contributor

This is bypassing the yaml deserialisation, can we add a test in ConfigProviderTests to just check this :)

@asbjornu
Copy link
Member Author

asbjornu commented Feb 1, 2016

@JakeGinnivan Doesn't the existing ConfigProviderTests.NextVersionCanBeInteger suffice? :)

Try to parse the `next-version` configuration value as a `System.Int32` and treat the parsed value as the major version number.
@asbjornu
Copy link
Member Author

asbjornu commented Feb 1, 2016

@JakeGinnivan I added a couple of more tests to ConfigProviderTest so it's in sync with the tests in ConfigNextVersionBaseVersionStrategyTests. I've also rebased.

JakeGinnivan added a commit that referenced this pull request Feb 1, 2016
@JakeGinnivan JakeGinnivan merged commit b4597ab into GitTools:master Feb 1, 2016
@asbjornu asbjornu deleted the feature/next-version-is-integer branch February 2, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants