.md links are not converted when they have a space

[piranna]

Links that point to a local .md file are converted to .html, but I've found that if the path has spaces this doesn't happens and is left as is, so they later doesn't work. This is causing too to show errors on the console about the hyperlinks are outside the spine when generating a PDF.

[k-rus]

I was hit with the issue. In my case it was enough to have spaces in the link text, while the link itself did not have any spaces. An example of not converted link:

[list of statements](statements.md)

statements.md is not converted into HTML and hyperlink goes to the MD file. The gitbook log contains warning:

warn: page README.md contains an hyperlink to resource outside spine 'statements.md'

EDIT: the above problem is due to different reason. So it is not related to this issue.

[piranna]

warn: page README.md contains an hyperlink to resource outside spine 'statements.md'

I think this error is not related with this bug according to what I understood about it, seems it's a security behaviour for ebooks, to be sure there are no dead links.

[k-rus]

I think this error is not related with this bug according to what I understood about it, seems it's a security behaviour for ebooks, to be sure there are no dead links.

I think you are right. It would be great if you can point me where I can read about the security behaviour.

[piranna]

I think you are right. It would be great if you can point me where I can read about the security behaviour.

I just searched about that error and point me to some ebook format documentation from Adobe, don't remember where.

[piranna]

Anyway, I think gitbook or calibre should be intelligent enough to detect this security issue could happen and format URLs so it doesn't warn to the user... This seems to be introduced about gitbook 2.3 or something similar.

[k-rus]

I just searched about that error and point me to some ebook format documentation from Adobe, don't remember where.

I was not so patient when I searched about the error. So far I haven't found any meaningful information about my error. I will continue to search. Thank you for the comment.

Anyway, I think gitbook or calibre should be intelligent enough to detect this security issue could happen and format URLs so it doesn't warn to the user... This seems to be introduced about gitbook 2.3 or something similar.

This problem is very annoying. My current work around is to include all my MD files into the global summary.

Thank you for your feedback and sorry for off-topic.

[akauppi]

Faced this. Changing the links themselves proved to be enough, and corrected the problem (spaces in link texts could remain).

$ ./node_modules/.bin/gitbook --version
CLI version: 2.3.0
GitBook version: 2.4.3

I would still like to see a bugfix, since it's surprising behaviour to end users.

nb. Having spaces in a link in SUMMARY.md is working. It's only the links between content that are affected by this.

[garyng]

Any updates for this issue?
Links with space in SUMMARY.md will be converted. But others(in the content) will not.

[iBobik]

Still not working

CLI version: 2.3.2
GitBook version: 3.2.3

[ljharb]

@addisonschultz can you link to a PR or commit that fixed this?

[addisonschultz]

Hi @ljharb - This version of GitBook has been deprecated for the last few years, and hasn't been under active development for a while. You can read more about that here: https://github.com/GitbookIO/gitbook/tree/legacy?tab=readme-ov-file

This repository is now home to the rendering engine of the most up-to-date version of GitBook. Further development of this version will continue to be found in this repository!

[piranna]

So, no, issues have been closed and this has not been fixed.