Fix missing alternative schemas #3058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26751e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Summary of the deployments: Version 1 (production)
Version 2 (experimental)
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the missing alternative schemas by modifying the condition that checks the existence of schema properties and updating the changeset information.
- Changed conditional check in OpenAPISchema.tsx to verify a non-empty properties array
- Added changeset entry for the patch version update
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-openapi/src/OpenAPISchema.tsx | Update condition to use optional chaining on properties |
| .changeset/chilled-eggs-attack.md | Document patch release with fix details |
Comments suppressed due to low confidence (1)
packages/react-openapi/src/OpenAPISchema.tsx:53
- The updated condition now only renders the disclosure when 'properties' is a non-empty array. Verify that an empty array should not trigger rendering, as this change excludes cases where an empty properties array might be valid.
if (properties?.length) {
gregberge
approved these changes
Mar 28, 2025
nolannbiron
deleted the
nolann/rnd-6730-openapi-option-not-expanding-in-published-site
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allOf was missing
Before:
After:
