Skip to content

Use react@19 on v2 and v1 #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2025
Merged

Use react@19 on v2 and v1 #3184

merged 12 commits into from
Apr 24, 2025

Conversation

jpreynat
Copy link
Member

@jpreynat jpreynat commented Apr 23, 2025

The v2 currently returns this error on some endpoints:

⨯ Error: Missing optional dependency "react-dom/server.edge"

By further inspecting the deployed code, the bundled react-dom version is 18, instead of 19.

The overrides at the root to use react@18 were indeed preventing v2 to use react@19.
But after some tests, it seems that react@19 also works properly for v1, so let's use it everywhere.

@jpreynat jpreynat self-assigned this Apr 23, 2025
Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 79ffa63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Apr 24, 2025, 1:18 PM
customers-v2 (Inspect) 👍 Changes approved 79 changed Apr 24, 2025, 1:21 PM
default (Inspect) ✅ No changes detected - Apr 24, 2025, 1:20 PM
v2-vercel (Inspect) 👍 Changes approved 1 changed Apr 24, 2025, 1:23 PM

@jpreynat jpreynat changed the title Remove overrides preventing to use react19 on v2 Use react@19 on v2 and v1 Apr 24, 2025
@jpreynat jpreynat marked this pull request as ready for review April 24, 2025 13:13
@jpreynat jpreynat merged commit 90f0127 into main Apr 24, 2025
20 checks passed
@jpreynat jpreynat deleted the v2-react19 branch April 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants