Skip to content

Conversation

emmerich
Copy link
Contributor

When we detect that a space is in the same site as the current page, we resolve relative.

e.g. Space changelog is in the same site as space api-docs. When we link from changelog to api-docs we resolve paths like /changelog/....

The problem is that a leading slash was not appended (we used changelog/...) so the link was being treat as if relative to the current space.

This fixes the issue.

Copy link

linear bot commented Jun 30, 2025

Copy link

changeset-bot bot commented Jun 30, 2025

⚠️ No Changeset found

Latest commit: 98f29e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 78 changed Jun 30, 2025, 2:37 PM
v2-cloudflare (Inspect) 👍 Changes approved 1 changed Jun 30, 2025, 2:41 PM
v2-vercel (Inspect) 👍 Changes approved 7 changed Jun 30, 2025, 2:40 PM

@emmerich emmerich merged commit 8fe9c9a into main Jun 30, 2025
16 checks passed
@emmerich emmerich deleted the stevenh/rnd-7455-most-relative-links-are-broken-for-docsrevroboticscom-on branch June 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants