-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix an issue where same-site references across spaces created invalid links. #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue where same-site references across spaces created invalid links. #3407
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
When we detect that a space is in the same site as the current page, we resolve relative.
e.g. Space
changelog
is in the same site as spaceapi-docs
. When we link fromchangelog
toapi-docs
we resolve paths like/changelog/...
.The problem is that a leading slash was not appended (we used
changelog/...
) so the link was being treat as if relative to the current space.This fixes the issue.