Improve Button and ButtonGroup styling
#3540
Merged
+102
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow Button to have contents and a label. The label will be used in tooltips, the contents will only ever be shown inside the button itself. - Adapt `AIChatButton` to have content & label - Add `:active` effect to `depth-subtle` buttons for a nice "pressing down" effect - Add `combinedShape` prop to `ButtonGroup` to enable/disable the shape grouping of buttons within the group - Use `Button` and `ButtonGroup` more consistently across the codebase, particularly in `PageFeedbackForm` and `ThemeToggler`.
🦋 Changeset detectedLatest commit: a50610c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
taranvohra
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIChatButtonto have content & label:activeeffect todepth-subtlebuttons for a nice "pressing down" effectcombinedShapeprop toButtonGroupto enable/disable the shape grouping of buttons within the groupButtonandButtonGroupmore consistently across the codebase, particularly inPageFeedbackFormandThemeToggler.