Add ScrollContainer component, use for section tabs #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A container that encapsulates a scrollable area with usability features. - Faded edges when there is more content than the container can display. - Buttons to advance the scroll position. - Auto-scroll to the active item when it's initially active.
🦋 Changeset detectedLatest commit: e49fe8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zenoachtig
had a problem deploying
to
2v-preview
GitHub Actions
Failure
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ScrollContainer component that provides scrollable areas with enhanced usability features, and refactors the section tabs navigation to use this component for improved user experience.
Key changes:
- Creates a new ScrollContainer component with faded edges, scroll buttons, and auto-scroll functionality
- Refactors SiteSectionTabs to use ScrollContainer instead of basic overflow scrolling
- Updates translations across multiple languages to support the new scroll controls
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/gitbook/src/components/primitives/ScrollContainer.tsx | New component providing enhanced scrollable container with navigation buttons and visual indicators |
| packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx | Refactored to use ScrollContainer and simplified navigation menu structure |
| packages/gitbook/src/components/primitives/Button.tsx | Enhanced button styles for better focus and state handling |
| packages/gitbook/src/components/Header/Header.tsx | Simplified header layout to use new SiteSectionTabs structure |
| packages/gitbook/src/components/Header/SpacesDropdown.tsx | Minor styling adjustment for translation dropdown |
| packages/gitbook/src/intl/translations/*.ts | Added translations for scroll button labels across 10 languages |
| packages/gitbook/src/components/RootLayout/globals.css | Added max-height for horizontal scrollbars |
| .changeset/*.md | Changelog entries for the new features |
Comments suppressed due to low confidence (1)
packages/gitbook/src/components/SiteSections/SiteSectionTabs.tsx:1
- For vertical orientation, the button should be at the bottom but uses 'mt-2' (margin-top). This should be 'mb-2' (margin-bottom) to properly position the button away from the bottom edge.
'use client';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…croll-through-site-sections-on
…croll-through-site-sections-on
zenoachtig
deleted the
zeno/rnd-8018-its-not-obvious-that-you-can-scroll-through-site-sections-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A container that encapsulates a scrollable area with usability features.
CleanShot.2025-09-17.at.17.43.04.mp4
CleanShot.2025-09-17.at.17.42.05.mp4